Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#120] Support aliases in tl visit. #122

Merged
merged 1 commit into from
Sep 20, 2019
Merged

[#120] Support aliases in tl visit. #122

merged 1 commit into from
Sep 20, 2019

Conversation

jibran
Copy link
Contributor

@jibran jibran commented Sep 20, 2019

Fixes #120

@jibran
[#120] Support aliases in tl visit.
d1e54e5 
Signed-off-by: Jibran Ijaz <jibran.ijaz@gmail.com>
jibran
jibran commented Sep 20, 2019
View reviewed changes
src/Commands/Visit.php
@@ -84,7 +87,7 @@ protected function open($url, OutputInterface $output) {
$browser = 'start';
}

if ($browser) {
if ($browser && !isset($GLOBALS['__PHPUNIT_BOOTSTRAP'])) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kind of ugly. Do we have a better way to do this?

Copy link
Owner

@larowlan larowlan Sep 20, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could put a constant in phpunit.xml and then use !defined()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's almost the same thing :D. I tested it locally it works. We can improve it later.

@jibran jibran mentioned this pull request Sep 20, 2019
Closed
@jibran jibran merged commit 4c89932 into master Sep 20, 2019
@jibran jibran deleted the 120-visit-alias branch September 20, 2019 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larowlan larowlan larowlan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support aliases in tl visit
2 participants
@jibran @larowlan